Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.33k stars 5.28k forks source link

[Docs] Add PROBE_SPEED paramter to PROBE_ACCURACY #6389

Closed hatkyinc2 closed 9 months ago

hatkyinc2 commented 11 months ago

Add PROBE_SPEED paramter to PROBE_ACCURACY documentation

image

JamesH1978 commented 10 months ago

Thank you for submitting a PR, please refer to https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and make sure you have provided some context to your change and you have added signed off by line.

Also not sure this command has a LIFT_SPEED option that can be set on the gcode command line.

Thanks

James

hatkyinc2 commented 10 months ago

image @JamesH1978 Does this example usage image satisfy you that this is a working config option?

hatkyinc2 commented 10 months ago

Sample of using all 4 options at the same time

image

hatkyinc2 commented 10 months ago

I've added the signature in the commit message

github-actions[bot] commented 10 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

KevinOConnor commented 10 months ago

Thanks. The change looks fine, but I don't see a signed-off-by line - please see the documentation at https://www.klipper3d.org/CONTRIBUTING.html#format-of-commit-messages

-Kevin

github-actions[bot] commented 9 months ago

It looks like this GitHub Pull Request has become inactive. If there are any further updates, you can add a comment here or open a new ticket.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.