Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.33k stars 5.28k forks source link

doc: update supported rpi device info #6398

Closed thijstriemstra closed 10 months ago

thijstriemstra commented 10 months ago

rpi 5 is out and instead of perpetually updating this text, omit the version nrs (which can be mentioned in the FAQ instead perhaps).

Signed-off-by: Thijs Triemstra info@collab.nl

JamesH1978 commented 10 months ago

Thanks for the PR, it might be best to list the versions that are not recommended like the original 2012 pi 1 and the zero 1, i would say the pi2 IMO iss getting a little underpowered these days too as functionality increases.

Also please refer to point 3 in "Common things a reviewer will look for:" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed-of-by line

Thanks James

github-actions[bot] commented 10 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

KevinOConnor commented 10 months ago

Thanks. Maybe word it with something like "a Raspberry Pi 2 (or later)". I would not recommend running Klipper on an rpi1 or rpi0.

-Kevin

thijstriemstra commented 10 months ago

thanks for the review, I made the changes @KevinOConnor

KevinOConnor commented 10 months ago

Thanks.

-Kevin