Closed xtoddx closed 7 months ago
Thank you for submitting a PR, please could you refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line.
Thanks James
Updated. Apologies for the oversight.
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html
There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
Thanks. However, this PR doesn't look like it would work correctly when multiple steppers are simultaneously assigned to the same extruder. It doesn't look correct to change the main extruder's reference to its specific stepper.
-Kevin
It looks like this GitHub Pull Request has become inactive. If there are any further updates, you can add a comment here or open a new ticket.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
Background
x-in-1-out hotend configurations currently require naming the tool in the slicer and adding an extra
extruder=...
paramter to SET_PRESSURE_ADVANCE g-code. Failure to add the parameter results in Unable to infer active extruder stepper errors and aborted prints on the first tool change (at least with PrusaSlicer-like software).As the error message states, there is an attempt to infer the value, but currently the value of printer.toolhead.extruder.extruder_stepper is always the primary extruder_stepper (the one named "extruder").
This updates the sync_to_extruder method so the printer model is kept consistent with the currently active extruder_stepper by assigning it to the PrinterExtruder.