search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.33k stars 5.28k forks source link

stats: add fan speed stats to log #6414

Closed CODeRUS closed 7 months ago

CODeRUS commented 10 months ago

Signed-off-by: Andrei Kozhevnikov coderusinbox@gmail.com

Sineos commented 10 months ago

Can you explain the rationale? The log output would never reflect all changes and also does not align to any layer information or similar. Additionally, I do not see any diagnostic benefit, but I might be missing something.

CODeRUS commented 10 months ago

@Sineos exactly for diagnostic purposes. Most common cases are ADC out of range errors after turning on part cooling fan. Can see if temperature goes down (probably) cause of turning on cooling.

CODeRUS commented 10 months ago

then i can check logs to see if there any problems

firefox_2023-12-01_22-02-33 (via)

github-actions[bot] commented 9 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

KevinOConnor commented 8 months ago

Thanks. As feedback, the code change here doesn't seem correct to me. The main diagnostic case (that I'm aware of) is reporting the "layer cooling fan" speed, but this change doesn't add a stats() callback to the PrinterFan() class. Maybe I'm missing something. If we do want to add more diagnostic info, I think we should restrict it to just the layer fan, as most other fans (eg, heater_fan) are unlikely to be needed for diagnostics.

-Kevin

github-actions[bot] commented 7 months ago

It looks like this GitHub Pull Request has become inactive. If there are any further updates, you can add a comment here or open a new ticket.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.