search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.99k stars 5.17k forks source link

Fixes for STM32G4 devices #6434

Closed eamaclean closed 6 months ago

eamaclean commented 6 months ago

The STM32G4 support never had USB or CAN tested, and changes to the STM32H7 ADC code in the meantime revealed a timing issue seen only as a small footnote in the reference manual.

Thanks to @mattthebaker for finding the USB issue first

KevinOConnor commented 6 months ago

Thanks. Looks fine to me. I'll give a few days to see if there are other comments.

-Kevin

mattthebaker commented 6 months ago

I can confirm from hardware tests that both the USB and ADC changes are effective and necessary.

Matt

On Mon, Dec 18, 2023 at 8:07 AM KevinOConnor @.***> wrote:

Thanks. Looks fine to me. I'll give a few days to see if there are other comments.

-Kevin

— Reply to this email directly, view it on GitHub https://github.com/Klipper3d/klipper/pull/6434#issuecomment-1860916470, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKHCKXGQJJVYZ7PG2I6LODYKBS4JAVCNFSM6AAAAABAYY3YF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQHEYTMNBXGA . You are receiving this because you were mentioned.Message ID: @.***>

KevinOConnor commented 6 months ago

Thanks.

-Kevin