Extend sermoon v1 configuration example

[arddennis]

Repo has only core definition for the printer and missing filament sensors. This change adds both filament and optional door sensor. Idea is to stop printing when filament runs out or door being open. LED pin added to the config to be able to turn LED light of the printer.

[JamesH1978]

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks James

[JamesH1978]

@duchengyao Anything to add to this? as this was your original PR?

If no objections I will review and likely approve shortly

Thank James

[duchengyao]

Looks good.  I will test this configuration as soon as possible.

[arddennis]

@JamesH1978 Sorry to ask an obvious question.

I just saw another Sermoon V1 Pro printer using a different pin for a runout sensor. What is the best practice to explain these details? Should I add a comment with instructions on how to test it and possible other options? Alternative settings is: switch_pin: !PC6 instead of PA3 on mine.

Also, there is a cr/bl-touch sensor connection outlet on the printer available. The sensor is not bundled with the printer by-default, but I managed to connect it and it works. Should I note these details as well in this commit or send you another PR to include this documentation as a comment in the text. Such could save me some time when I searched for the info...

[JamesH1978]

We do not include instructions to do testing in configurations. We only include options for a stock machine.

If connecions are available on the board for probes with clearly defined pins then these can be included in the configuration but commented out.

This is the same for a run out sensor if it is stock and comes with a printer then the pin should not be different. This does not stop someone buying this printer and adding a 3rd party sensor and using a different pin but that is outside the scope of these configurations.

[github-actions[bot]]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

[github-actions[bot]]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.