search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.98k stars 5.17k forks source link

WS2801: Support for WS2801 LEDs using SW SPI and HW SPI #6484

Open akrto opened 4 months ago

akrto commented 4 months ago

Since none of the existing LED drivers worked properly with WS2801 LED modules this driver was added. Tested on Arduino Uno Will not pass all regression tests due to dict files being outdated on gh.

KevinOConnor commented 4 months ago

Thanks. I'm not very familiar with this LED type. How does it differ from the existing "dotstar" module?

-Kevin

akrto commented 4 months ago

Thanks. I'm not very familiar with this LED type. How does it differ from the existing "dotstar" module?

-Kevin

In short, the protocols are different :-)

The Dotstars (APA102) has framing built into the protocol, meaning that it is not affected by pauses in the data that would be caused by the entire data not fitting into one message from Host to MCU-board running the LEDs. There is about 40 bytes of data in each message right? APA102 also has global dimming, which is something that the WS2801 doesn´t.

The WS2801 relies on pauses between messages for framing, meaning that if not all data could fit into one message from host to MCU it would start all over with the data in the next message. Because of that, I had to implement local LED-registry on the MCU-board, a´ la Neopixel style.

Thank you for all the hard work you guys put into this project, you guys rock!

Framing/protocol for Dotstars/APA102: image

Framing/protocols for WS2801: image

github-actions[bot] commented 3 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.