Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.98k stars 5.17k forks source link

scripts: Added shaper tuning parameters to calibrate_shaper script #6487

Closed dmbutyugin closed 4 months ago

dmbutyugin commented 4 months ago

The added parameters include square_corner_velocity, shaper frequencies to optimize, input shapers to test, input shaper damping ratio and damping ratios to test. All these options can be useful for fine-tuning the input shapers when the default suggestions generated by the tuning script are not optimal.

Also the SHAPER_CALIBRATE command was modified to pass some of these parameters to the shaper tuning routine. Specifically, square corner velocity and the maximum tested frequency are used to adjust shaper tuning and maximum acceleration recommendations.

I think the possibility to specify the square_corner_velocity is most useful. Some people change it against the recommendations, but may use the same maximum acceleration recommendations from the script without realizing that they should be adjusted. This change allows them to get better estimates for maximum accelerations and potentially make better and more informed decisions about raising square_corner_velocity parameter. Then the possibility to tune only a subset of shapers and specific frequencies may be useful for advanced users who wanted to do fine-tuning of the shapers, but lacked the tools to do so.

KevinOConnor commented 4 months ago

Thanks. Let me know when you'd like me to merge this.

Cheers, -Kevin

EDIT: Or more specifically, if there are no further comments on this in the next few days then I'll plan to merge this.

KevinOConnor commented 4 months ago

Thanks.

-Kevin