Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.98k stars 5.17k forks source link

BDsensor: adding support for new probe sensor BDsensor #6490

Open markniu opened 4 months ago

markniu commented 4 months ago

adding support BDsensor for Fast auto bed leveling leveling. About BDsensor: It can measure the bed distance at any point in real time without moving the z axis up and down. now the fast auto bed leveling is stable for pull, there will be more new features like real time adjust and strain gauge in the future.https://github.com/markniu/Bed_Distance_sensor Config: https://github.com/markniu/Bed_Distance_sensor/wiki/Installing-for-Klipper

Sineos commented 4 months ago

Thanks a lot for your contribution. Please also provide the signed off as per point 3 in "What to expect in a review" in master/docs/CONTRIBUTING.md

Also, it would need to come with an update of the documentation in the relevant chapters, e.g. "bed level" and "g-codes"

github-actions[bot] commented 3 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

KevinOConnor commented 3 months ago

Thanks. Is this sensor based on the ldc1612 chip? There has been some work done on that chip at #6536 (and #6537).

My high-level feedback is that I think we need to integrate these efforts into a single "probe_eddy_current.py" type of module. I think we want to avoid having each probe implement their own implementations of PROBE, PROBE_ACCURACY, homing, etc.

-Kevin

markniu commented 3 months ago

hello Kevin, thanks! this sensor is not based on ldc1612 chip, it is based on the TCA355G that is a traditional inductive proximity switch sensor chip, some other DAC chip and analog electrical component to change the eddy current, not like the ldc1612 which change the eddy frequency to measure the distance.

beside it can output the distance value or raw DAC data via the i2c port, it can also work as a switch sensor (just output low/high level in the sda pin) while homing, that helps to consumes low mcu usage.

with the new feature nozzle collision sensing that use the raw DAC value to adjust the z_offset automatically.

Thanks. Is this sensor based on the ldc1612 chip? There has been some work done on that chip at #6536 (and #6537).

My high-level feedback is that I think we need to integrate these efforts into a single "probe_eddy_current.py" type of module. I think we want to avoid having each probe implement their own implementations of PROBE, PROBE_ACCURACY, homing, etc.

-Kevin

markniu commented 3 months ago

I agree, and it is no problem to remove the PROBE and PROBE_ACCURACY in the BDsensor.py and use the PROBE, PROBE_ACCURACY in the probe.py.