search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.98k stars 5.17k forks source link

Fix building for "Linux Process" in non-FHS environments #6493

Closed MadnessASAP closed 2 months ago

MadnessASAP commented 4 months ago

This PR addresses building the Klipper "Linux Process" MCU on filesystem layouts that don't adhere to the FHS standard (i.e. NixOS) . It replaces the absolute include paths in main.c and gpio.c with relative paths. It also adjusts CFLAGS to use -iquote to prevent conflicts when resolving quoted "includes" and .

The finest of "builds for me" testing was carried out successfully.

CRTified commented 4 months ago

Thanks, I just looked into setting up the host MCU and ran into this issue. This PR fixed compilation for me :)

MadnessASAP commented 4 months ago

Thanks, I just looked into setting up the host MCU and ran into this issue. This PR fixed compilation for me :)

Glad it helped, are you also running on NixOS by chance? I'm also putting some TLC into the nixpkg module.

CRTified commented 4 months ago

are you also running on NixOS by chance?

Yes, I am. Feel free to ping me on matrix (@crtified:crtified.me), I got the host mcu working on NixOS already :)

github-actions[bot] commented 3 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

cnf commented 3 months ago

Discord Link to a discussion about this.

KevinOConnor commented 2 months ago

Thanks. It seems fine to me. Could you split the line in the Makefile so it does not exceed 80 characters though?

-Kevin

MadnessASAP commented 2 months ago

Thanks! Makefile corrected for the non-ultrawide proletariat.

KevinOConnor commented 2 months ago

Thanks.

-Kevin