Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.98k stars 5.17k forks source link

feat(klippy, toolhead): add S<seconds> param to G4 command #6499

Closed slaesh closed 4 months ago

slaesh commented 4 months ago

this adds the ability to pass an S<seconds> parameter to the G4 dwell command. its even possible to combine the existing P<milliseconds> with the newly added S param.

took me a while to realize that klippers G4 interpreter only used the P param.. :))

To-Do:

Signed-off-by: Sascha Ehlers sascha@ehle.rs

pedrolamas commented 4 months ago

My understanding is that Klipper is not trying to replicate the full Marlin gcode support, hence why this is not implemented.

For now, you can easily fix this issue by overriding G4 with a custom macro:

[gcode_macro G4]
rename_existing: G4.1
gcode:
  G4.1 P{ params.P | default((params.S | default(0) | int) * 1000) }

The above will allow you to use either P or S params.

slaesh commented 4 months ago

thanks for the hint. before doing that, I will keep adding some zeros here and there ;)

otherwise shared config's wont work anymore on another klipper instance :)

in my feeling this doesnt hurt, but sure it does not add so much value either. since no one requested this earlier, at least cant find any related issue.. I will close this one then =)