Update Measuring_Resonances.md

[charminULTRA]

Current commands in the documentation, using the , results in bad chart output when more than one .csv file exists in the tmp folder. This isn't obvious for people who may not know that the is a wildcard character.

I was pulling out my hair trying to understand my results until I realized my multiple runs of data were all being used in the same graph! I think this simple pitfall should be fixed.

[freakydude]

I used this as a feature - so you can measure multiple times (e.g. with a full and empty spool on top) and the results will be merged.

If that was the intention, I would comment the script line with - "be aware, all matching csv will be merged" or something like that.

Kind regards

[JamesH1978]

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks James

[github-actions[bot]]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

[dewi-ny-je]

@charminULTRA can you apply the corrections I suggested? then we can hopefully have the changes approved

[charminULTRA]

@charminULTRA can you apply the corrections I suggested? then we can hopefully have the changes approved

I don't see any suggested corrections, where can I view that? @dewi-ny-je

[charminULTRA]

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks James

@JamesH1978 How do I add a sign off if I already submitted the commit?

Not entirely so sure why this is so rigorous considering the Klipper documentation still assumes use of OctoPrint lol

[dewi-ny-je]

@KevinOConnor for as much as it can be worth, I now support and I checked the changes. I think they are ready to be merged.

[KevinOConnor]

Thanks. Looks fine to me. I'll wait a few days to see if @dmbutyugin has any comments.

-Kevin

[charminULTRA]

Bump

[KevinOConnor]

Okay, thanks. If there are no further comments I'll look to commit in a few days.

-Kevin

[dmbutyugin]

OK, thanks, I'm also fine with the current version of the notice.

[KevinOConnor]

Thanks.

-Kevin