Closed TheParanoidEngineer closed 3 months ago
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html
There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
In principle, I see no problem with this change. It seems this should also work on ubuntu (and ubuntu-based armbian). However, the code contributions need to follow the guidelines. Specifically here, the commit(s) need to have a signed-off-by line with the real name (see point 3 there).
In principle, I see no problem with this change. It seems this should also work on ubuntu (and ubuntu-based armbian). However, the code contributions need to follow the guidelines. Specifically here, the commit(s) need to have a signed-off-by line with the real name (see point 3 there).
Maybe I am not understanding, but is the below by-line in my original post not sufficient?
The change makes sense.
Indeed, I also missed the fact the libopenblas-base
is handled differently between the major releases. libopenblas-dev
is a common denominator.
Thanks.
-Kevin
[Module] Measuring_Resonances
[Change Point] Changed
libopenblas-base
tolibopenblas-dev
.[Change Reason] Current instructions cause NumPy installation failure on host machines running Debian Bookworm.
The table above shows that
libopenblas-base
is not supported by Bookworm, whilelibopenblas-dev
is supported by all three.This change should have improved compatibility with host devices (especially with more devices moving to Bookworm).
[Test Result] The new instructions have been tested on a fresh install of PiOS Lite (Bookworm) on a Pi5. NumPy (and supporting packages) were installed successfully without errors:![image](https://github.com/Klipper3d/klipper/assets/158858389/fd715ce7-a9e2-49d3-8b6e-7ed83b15673b)
Signed-off-by: Philip Weber philiprweb@gmail.com