Closed rakosi2 closed 3 months ago
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.
Thanks James
As mentioned over in the discord a lot of other stm32 chips use AF7 for this UART, Especially ones used in the 3D printing world like the F4 and the H7 series. You will need to rewrite your code to be specifically for the G0 series using AF0
Thanks James
Set it to only change for STM32G0 series to AF0 and all other STM32 will use AF7 I have also fix the Signed-off-by Thank you JamesH1978
Thanks. The change looks fine to me, but I don't see a singed-off-by line though.
-Kevin
I was unaware of it on the first commit, put it on the second commit and edited the first message with the signed-off at the end.
Sorry - I'm still not seeing it. I need to see a line that looks something like Signed-off-by: Some Name <some@email.addr>
. The line can be either in a comment here or in a commit message - I don't see a line like that in either location.
Cheers, -Kevin
EDIT: I do see your name and email address in the second commit message, but I don't see the leading "Signed-off-by:" signature indicator.
Signed-off-by: Attila Rakosi rattila5@hotmail.com
Thanks.
-Kevin
I have a BTT E3EZ (STM32G0B1) and the UART on the TFT did not work. I have worked out that the ALT mux was not set correctly. This is the only board that I can verify with so I am not sure if this is a typo or if another chip needs it as AF7. I have not looked at the other USARTs since I can not verify it.
This will resolve this issue: https://github.com/bigtreetech/Manta-E3EZ/issues/8
Attila Rakosi rattila5@hotmail.com