search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.95k stars 5.16k forks source link

probe_eddy_current: implement surface scannng #6537

Closed Arksine closed 2 months ago

Arksine commented 2 months ago

This PR build on #6536, adding support for "surface scanning". The first commit resolves a minor issue where PROBE_EDDY_CURRENT_CALIBRATE removes all previous autosaved configuration, including the reg_drive_current option saved by LDC_CALIBRATE. If necessary this commit can be removed from this PR and added to another (or to the original).

The rest of this PR makes the necessary modifications to probe_eddy_current.py, probe.py, and bed_mesh.py to support scanning a surface using an eddy probe. In addition, a graph-mesh.py script has been added to visualize and analyze mesh state, which can be dumped to a json file using the new BED_MESH_DUMP command.

KevinOConnor commented 2 months ago

Thanks. I added your fix to PR 6536 and rebased that branch.

Separately, I'll roughly plan on merging PR 6536 into the main repo first, and then look to merge this afterwards. Let me know if you have any concerns with that.

Cheers, -Kevin

Arksine commented 2 months ago

Sounds good to me. I rebased this against your changes for now and can rebase against master before merging if necessary.

github-actions[bot] commented 2 months ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Arksine commented 2 months ago

Hi Kevin, it looks like GitHub automatically closed this PR since I created it against the work-ldc branch. I went ahead and created a new PR rebased against the latest master. Thanks.

KevinOConnor commented 2 months ago

Oh - sorry - I did not realize github would do that. Thanks for creating the new PR.

-Kevin