Closed KevinOConnor closed 2 months ago
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html
There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
The
on_gcode_error
parameter allows one to run a set of g-code commands if an error is found while running a print using the virtual_sdcard system. (Which is very common, as all the Klipper graphical frontends use this system to print.)There is currently no default for this parameter. That's not ideal, as an error that occurs during a print could result in the toolhead stopping with the heaters enabled and the nozzle directly over a partial print.
This PR adds a default - if the parameter is not specified it will default to
TURN_OFF_HEATERS
. I think this is likely an improvement over the existing behavior.Arguably, it would be even better to also raise the Z a few millimeters on a host detected command error. Unfortunately, it's difficult to do that reliably, and I fear it may be too complex to be a good default. So, this PR is a compromise - it just turns off the heaters by default.
Note that the motors are not disabled by a host detected command error in a virtual_sdcard print (neither before this PR nor after it).
-Kevin
P.S. I did come up with the following possible macro to try to raise the Z. I wasn't happy with it because of its complexity (and there are still cases where it would not work correctly):