search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.93k stars 5.15k forks source link

Add config files for Recore A6, A7 and A8 #6567

Closed eliasbakken closed 2 weeks ago

eliasbakken commented 2 months ago

The ina381 is a current monitor circuit with over current alarm. In order for Recore boards to work, this circuit needs a reset and that is what this plugin does.

Signed-off by: Elias Bakken elias@iagent.no

eliasbakken commented 1 month ago

I've implemented this PR as a pure config file change as pr your suggestion.

KevinOConnor commented 1 month ago

Thanks. In general, it seems fine to me. At a minimum the configs need to be added to the build test cases though ( https://www.klipper3d.org/Example_Configs.html point 4).

@JamesH1978 - do you have any comments?

-Kevin

JamesH1978 commented 1 month ago

Config looks fine, my only main comment would be why you have such a low min_extrude_temp and a min_temp of 1 kelvin for your extruders?

Once the regression tests are added as per Kevin's comment, i will do a few review.

Thanks James

eliasbakken commented 2 weeks ago

Thank you both. I've added the config files as tests, but in order to make them pass I had to make some code changes, so I'll try and submit that as a separate PR that can be reviewed first.