Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.95k stars 5.16k forks source link

Add new pin set for spi2 on stm32g0 chips #6569

Closed Doncuppjr closed 1 month ago

Doncuppjr commented 2 months ago

This is an update to the pasren89 patch for the naming convention of new spi pin sets. modified: src/stm32/spi.c

Doncuppjr commented 2 months ago

I have tested this patch. This enabled hardware SPI for the extruder stepper TMC2240 and ADXL345 accelerometer on the BTT SB2240 CAN board.

[adxl345] cs_pin: can: PB12 spi_bus: spi2_PB2_PB11_PB10 axes_map: z,-y,x

[tmc2240 extruder] cs_pin: can: PA15 spi_bus: spi2_PB2_PB11_PB10 driver_TPFD: 0 run_current: 0.650 stealthchop_threshold: 999999

JamesH1978 commented 2 months ago

Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.

Thanks James

Doncuppjr commented 2 months ago

The pasrens89 patches refer to https://github.com/pasren89/klipper.git commits for which there was also a PR, e4e3c15f7d348a5e986093f41fc2cf693ab7d9d4 ddf63fb47950e90ce402f3f0a9356514a533ccc8

dominovox commented 2 months ago

I tested this patch on my EBB36 V1.2 CAN board with the ADXL345 on hw spi and it works as it should. Thx!

[adxl345] cs_pin: EBB: PB12 spi_bus: spi2_PB2_PB11_PB10

github-actions[bot] commented 1 month ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

JamesH1978 commented 1 month ago

@KevinOConnor any input on this one?

Thanks

KevinOConnor commented 1 month ago

Looks fine - thanks.

-Kevin