Closed Doncuppjr closed 1 month ago
I have tested this patch. This enabled hardware SPI for the extruder stepper TMC2240 and ADXL345 accelerometer on the BTT SB2240 CAN board.
[adxl345] cs_pin: can: PB12 spi_bus: spi2_PB2_PB11_PB10 axes_map: z,-y,x
[tmc2240 extruder] cs_pin: can: PA15 spi_bus: spi2_PB2_PB11_PB10 driver_TPFD: 0 run_current: 0.650 stealthchop_threshold: 999999
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.
Thanks James
The pasrens89 patches refer to https://github.com/pasren89/klipper.git commits for which there was also a PR, e4e3c15f7d348a5e986093f41fc2cf693ab7d9d4 ddf63fb47950e90ce402f3f0a9356514a533ccc8
I tested this patch on my EBB36 V1.2 CAN board with the ADXL345 on hw spi and it works as it should. Thx!
[adxl345] cs_pin: EBB: PB12 spi_bus: spi2_PB2_PB11_PB10
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html
There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
@KevinOConnor any input on this one?
Thanks
Looks fine - thanks.
-Kevin
This is an update to the pasren89 patch for the naming convention of new spi pin sets. modified: src/stm32/spi.c