Closed Yatin-Khurana closed 1 month ago
Thank you for submitting a PR, please refer to https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and point 4, and adding the printers.test file for regression tests.
Thanks James
Hi James, Thank you for notifying me, I've updated the PR, please check, Thanks!
Thanks, but looks like the build tests threw an issue, sensor_type = NTC10K
does not exist in klipper in your Chamber temperature_fan.
Thanks James
Can i ask why you have stated 115200? most known klipper compatible mcu's are able to run at the default 250000 in any mode, usb or serial uart?
Thanks James
No specific reason actually. I Initially tested it with a preconfigured HC-05 to connect to SBC, so I never updated, If preferred I can change it to 250000.
We would prefer the default 250000, unless their is a hardware reason for it to be lower, but that is not usually the case in 99.9% of boards
Thanks James
Sure, that's good only, I've updated the config.
Hi James, The config has been updated, please have a look. Thanks.
Is this a mass produced board? We typically ask that hardware support in the main Klipper repo have a real-world audience of at least a 100 users ( https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review ).
Thanks, -Kevin
Sure, That’s Understandable. Thanks Kevin
Added Config file for open source 3D printer mainboard SmartprintCoreH7x - https://github.com/BoltzRnD/SmartPrintCoreH7x
Signed-off-by: Yatin Khurana (yatinkhurana@protonmail.com)