Closed jayofelony closed 1 month ago
Please also refer to the example config document for what to include and what not to include in an example configuration. You have no header explaining flash instructions, and you have included superfluous macros and you have commented out PID sections in your heaters. I will do a full review once you have added the signed off by line and the regressions test.
Thanks James
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html
There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.
Best regards, ~ Your friendly GitIssueBot
PS: I'm just an automated script, not a human being.
Thank you for submitting a PR, pleas refer to point 3 in "What to expect in a review" in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and provide a signed off by line.
Also please refer to point 4 in the guidelines in the following link and add the printers.test with your new file for regression testing https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md
Thanks James