search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
8.98k stars 5.17k forks source link

Skew angle innacuracy (or maybe hidden math joke) #6614

Closed bharrisau closed 2 weeks ago

bharrisau commented 2 weeks ago

https://github.com/Klipper3d/klipper/blob/49c0ad6369670da574f550aa878ce9f6e1899e74/klippy/extras/skew_correction.py#L93-L95

So calc_skew_factor returns the tan of an angle - but the print statement is referring to it as the actual angle. Should probably be printing the arctan of the skew factor for correctness.

But if you apply the fundamental theorum of engineering - we know that sin(x) = tan(x) = x. So the actual printed values are still really close to the true angles.

jakep82 commented 2 weeks ago

We don't use GitHub to report or track issues.

https://www.klipper3d.org/Contact.html#i-found-a-bug-in-the-klipper-software

github-actions[bot] commented 2 weeks ago

It looks like this ticket is a request for help (or similar). Many helpful people will not see your message here and you are unlikely to get a useful response. Instead, see the contact directions at: https://www.klipper3d.org/Contact.html

We use github to share the results of work done to improve Klipper. We don't use github for requests. (In particular, we don't use github for feature requests, to answer questions, nor to help diagnose problems with a printer.)

Please follow the directions at: https://www.klipper3d.org/Contact.html

This ticket will be automatically closed.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.