search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.56k stars 5.34k forks source link

docs: Fixed dead link to MainsailOS #6710

Open ThatColdToast opened 1 month ago

JamesH1978 commented 1 month ago

Looks fine to me, but please also be aware that you need to sign off a PR, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

github-actions[bot] commented 2 weeks ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

JamesH1978 commented 2 weeks ago

@ThatColdToast if you could just add your signed off by line, we can get this approved and merged, if you are unwilling to do this, then i can go ahead a push a PR myself.

Thanks James

JamesH1978 commented 2 weeks ago

Thanks for adding that typo change, but i still dont see a signed off by line, so i can review and accept it.

Thanks James