search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.56k stars 5.34k forks source link

Slightly expand BL Touch explanation of Pin configuration #6724

Open do3cc opened 3 weeks ago

do3cc commented 3 weeks ago

Stating why the pullup is needed might help people who found wrong examples in the internet for probe configuration.

JamesH1978 commented 3 weeks ago

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

Sineos commented 3 weeks ago

TBH, I'm not sure if this not rather increases the confusion. Most users do not know what the pull-up actually does and even less so what an open-drain is. For those who know both terms and what they do, the explanation is not needed.

do3cc commented 3 weeks ago

Added Signed off and follow the preferred format.

do3cc commented 3 weeks ago

Maybe I am an outlier. I was stuck by this for two nights, being new to klipper and having used the Probe successfully with Marlin. I just see now that even the sample config from Bigtreetech is wrong about it. During my extensive googling, I got the impression, must people do not understand the consequences of Open Drain and Pullups. I do not dabble with microcontrollers regularly enough, so I only started to realize what was happening after I got and working. The Failure mode being working somewhat doesn't help either. Therefor I thought it is a good addition.

But I trust your judgement whether it reduces help requests by BLTouch users or adds confusion.

Independent of that, I will create a PR for the Bigtreetech sample config.

do3cc commented 3 weeks ago

There is already an ignored Pull Request and at least 7 open issues regarding that PIN and at least mentioning Klipper. 19 Bugs when also looking for Marlin. Meh, I didn't know how BTT treats the support of their hardware. I will create a new pull request for the example config of the SKR Mini Board with a section for BLTouch which is outcommented. My problem seems to be SKR Mini specific.

github-actions[bot] commented 1 week ago

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.