search

Klipper3d / klipper

Klipper is a 3d-printer firmware
GNU General Public License v3.0
9.58k stars 5.34k forks source link

Update install-debian.sh #6737

Closed tekweaver closed 1 week ago

tekweaver commented 2 weeks ago

apt packages: python-dev -> python-dev-is-python3 libusb-1.0 -> libusb-1.0.0

python virtual environment: python2 -> python3

JamesH1978 commented 2 weeks ago

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

tekweaver commented 1 week ago

I would like to start by first apologizing. This is the first time I have submitted a pull request and still new to all git has to offer. Python 2 has been EoL since 2020/01/01. I thought to myself "since I HAVE to edit the debian install script every time I download klipper I can contribute a solution to a problem.

The debian install script has not been updated for 2 years.... Python2 went EOL in 2020... FOUR years ago... I was trying to be kind... But fk off trying to get me to sign a legal document for tying to be kind to my fellow human beings.... something to benefit all of us.

THIS RIGHT HERE is a reason to NEVER CONTRIBUTE and just keep an updated fork with my own edits.

jakep82 commented 1 week ago

Did you read the document? It effectively just states that you certify you have the right to submit the code.

The only goal is to prevent people from submitting code they didn't write and for which they have no legal copyright.