Klocman / Bulk-Crap-Uninstaller

Remove large amounts of unwanted applications quickly.
https://www.bcuninstaller.com/
Apache License 2.0
12.22k stars 607 forks source link

Dark ui mode? #228

Open GrosBourrin opened 5 years ago

GrosBourrin commented 5 years ago

all in the title ! it's only a suggestion ! keep up the good work

Klocman commented 5 years ago

Dark mode has been on my wish list for quite some time now. It will have to wait for a major UI update sadly.

GrosBourrin commented 5 years ago

no problem :)

Rexogamer commented 5 years ago

Where are the UI elements kept?

Klocman commented 5 years ago

@Rexogamer All UI is made in WinForms, it should be easy to tell where they are from the Solution view in Visual Studio. Elements are mostly in Controls and Forms folders, but some of them are spread across different libraries. Adding a dark mode would either require a lot of prodding around and nasty workarounds, or rewriting the UI in WPF or some other framework.

aha999 commented 4 years ago

Any updates on the dark theme ?

CanDincer commented 4 years ago

Dark mode would be soo nice.

TheLongLife commented 4 years ago

Dark theme in a style of NetLimiter-s dark theme would be nice.

ghost commented 4 years ago

Dark mode...? :(

Dhyfer1 commented 3 years ago

It is difficult to implement a dark theme for BCU? 2 years ago this issue was created and there is still no dark theme. How much longer will we have to wait?

sync1211 commented 2 years ago

I've tried to implement a basic dark mode functionality.

Splashscreen_Dark

Main_Dark

It is currently just iterating over all controls to change their colors, but I'm unsure if that's the recommended way of doing this.

Any feedback is greatly appreciated.

Macleykun commented 2 years ago

I've tried to implement a basic dark mode functionality.

Splashscreen_Dark

Main_Dark

It is currently just iterating over all controls to change their colors, but I'm unsure if that's the recommended way of doing this.

Any feedback is greatly appreciated.

Is this toggeable? Is this something you would wanna merg @Klocman ?

sync1211 commented 2 years ago

Is this toggeable?

It's controlled via a settings option, but requires a restart of the software.

Unfortunately there are still a few things that need fixing before I can make a pull request Menu1Menu2

Macleykun commented 2 years ago

Is this toggeable?

It's controlled via a settings option, but requires a restart of the software.

Unfortunately there are still a few things that need fixing before I can make a pull request Menu1Menu2

It’s looking promising that’s for sure :) looking forward to your pull friend!

ghost commented 2 years ago

Any news on this yet? Would really love a dark mode because the white is blinding.

sync1211 commented 2 years ago

Unfortunately there are still a few issues that I need to fix before I can make a PR.

grafik grafik grafik (^ Should show a preview of the colors used in the table)

Marcuswright1 commented 1 year ago

Dark Mode would be much appreciated in Win11 style. @Klocman Btw love this awesome software would be more than happy to support this project.

NebulaTechs commented 1 year ago

那什么时候才能界面大更新?

GrosBourrin commented 1 year ago

那什么时候才能界面大更新?

In english please!

NebulaTechs commented 1 year ago

Next UI update suggestion refer to Windows 11

Dhyfer1 commented 1 year ago

Four years have passed since this issue was created, and two years have passed since my last reply. https://github.com/Klocman/Bulk-Crap-Uninstaller/issues/228#issuecomment-894218972 Really, the author seems to have no interest in implementing a dark theme for BCU, I really think it's hard for him and I can say the same for the VLC development team.

How much longer will we have to wait!?

sync1211 commented 1 year ago

The main issue is that the software is using WinForms which doesn't include any fancy theming ability. As a result, every control needs to have their colors adjusted manually.

Unfortunately not every control has an option for changing its color or doesn't display correctly when recolored. (As you can see in my last comment.)

NebulaTechs commented 1 year ago

Telerik UI for WPF

Klocman commented 1 year ago

How much longer will we have to wait!?

As I've said before, I don't really have time to spend on a large rewrite required to jump to a window framework that supports themes, especially since it wouldn't add any functionality (and might even require removing some existing functionality).

If someone is willing to do this, feel free to send PRs.

Marcuswright1 commented 1 year ago

nvm us, we all appreciate all the work & effort you have put into building this really great app. It's just that we all love dark mode so much & u might be a fan too. But seriously I didn't know what goes behind the curtains while developing, as u explained above & in an old thread #75 it clears for me why dark mode isn't easy to implement. thanks for your contribution @Klocman

NekoJonez commented 1 year ago

I'm sorry to bump this issue... But, currently we have in the "view" menu we have a "Use System Theme". I'd remove that for the time being unless Dark Mode is coming to v5.8 ... Since, it might confuse users thinking there is a dark mode whilst there is none at this moment.

Saud-97 commented 1 year ago

Thank you @Klocman and other contributors for your hard work. Hopefully someone who has some time can do a UI overhaul. Sadly I mainly develop Kotlin and Android atm.

gregk-git commented 4 months ago

Unfortunately there are still a few issues that I need to fix before I can make a PR.

grafik grafik grafik (^ Should show a preview of the colors used in the table)

@sync1211 or @Klocman can you please make a PR to push the branch "DarkTheme" from sync's repo to this repository, so that it's more visible?

branch in question: https://github.com/sync1211/Bulk-Crap-Uninstaller/tree/DarkTheme

@sync1211 Could you please highlight blockers and where you need help?

@Klocman when we get more visibility into this, it will help other people who love this app to help out. I will take a look at it but C# is not my forte. Sync did a lot of the work but as usual the first 80% is easier than the last 20% due to weird edge cases and bugs.

sync1211 commented 4 months ago

@sync1211 Could you please highlight blockers and where you need help?

Currently, many elements don't show up correctly when using dark theme:

anime-shed commented 1 month ago

I came here thinking dark mode was working for BCUninstaller but seeing this active issue; it did not seem to be the case. And I am wondering here how I got mine to respect dark mode:

image

I only have some issues with the Highlight uninstaller.

sync1211 commented 1 month ago

Judging by the icons on the top right, you have some kind of mod/theme installed which likely allows for recoloring of WinForms apps.

However it appears to be having similar issues as the ones I've encountered while trying to implement a dark mode. For example; The colors on the graph and list don't appear to be displaying correctly.

Are your Toolbars and Drop-Down menus themed correctly?

anime-shed commented 4 weeks ago

There can be some improvement, though: image image image image

sync1211 commented 4 weeks ago

May I ask what theme/UI mod you're using?

It looks like it fixed most, if not all the issues I currently have with my implementation.

anime-shed commented 3 weeks ago

@sync1211 Theme I will just say you need to keep these disabled: image else it looks like this: image