Klonan / Mining_Drones

Mining drone mod for Factorio
GNU Lesser General Public License v3.0
13 stars 14 forks source link

Space Age #22

Open Serverfrog opened 1 month ago

Serverfrog commented 1 month ago

I don't think i need to write more ;)

basically updating to base >=2.0 but i don't know how much changed or if its even still possible

JamieRCHI commented 1 month ago

I had it working this morning, but now it crashes at line 12 of data-final-fixes.lua. From factorio-current.log: Error ModManager.cpp:1733: Failed to load mod "Mining_Drones": core/lualib/collision-mask-util.lua:70: attempt to index field 'layers' (a nil value) stack traceback: core/lualib/collision-mask-util.lua:70: in function 'collect_prototypes_with_layer' __Mining_Drones__/data-final-fixes.lua:17: in main chunk 2.037 Loading mod core 0.0.0 (data.lua) 2.102 Checksum for core: 1432597613 2.122 Error ModManager.cpp:1733: Error in assignID: procession with name 'default-b' does not exist.

dpwhittaker commented 1 month ago

You can fix this by moving

local drone_layer = ... data:extend(drone_layer)

From the top of data-final-fixes.lua to the bottom of data.lua. The prototype needs to be established in the prototype phase to be available to the collision-mask-util. Then back in data-final-fixes replace drone_layer.name with "mining_drone".

Also, custom_drop_offsets need to be 0, 4, 8, 12 instead of 0,2,4,8 in mining_depot.lua to handle the new 16 directions.

Edit: created a PR https://github.com/Klonan/Mining_Drones/pull/23

JamieRCHI commented 1 month ago

The "mining-drone" above threw me off a bit. Should be "mining_drone". Anyway, all is good and works now. Thanks a lot.

And here is my version of the mod. It will probably take awhile for the fixes to be merged with someone with 'write access'. I increased the stack size to 200, changed the recipe a bit for the 'station', and increased the speed that the mining drones are built.

Mining_Drones_2.0.0.zip

dpwhittaker commented 1 month ago

Woops, fixed the comment. The PR was right.

JamieRCHI commented 1 month ago

Thanks.