Klortho / Physics-Unit

Perl Physics::Unit module
http://search.cpan.org/perldoc?Physics::Unit
Do What The F*ck You Want To Public License
9 stars 4 forks source link

fix: use correct operator for exponentiation #32

Closed churib closed 8 years ago

churib commented 8 years ago

This pull requests fixes the computation of prefixes like kibi, mebi, kibi, ... Perl uses the \ operator for exponentiation, the operator ^ is used for bitwise xor.

Klortho commented 8 years ago

Thanks! I suppose I should do a new release, huh? It's been a long time since I've messed around with cpan.

jberger commented 8 years ago

I can do it (or help) as you prefer.

On Wed, Jun 29, 2016 at 3:26 PM Chris Maloney notifications@github.com wrote:

Thanks! I suppose I should do a new release, huh? It's been a long time since I've messed around with cpan.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Klortho/Physics-Unit/pull/32#issuecomment-229535843, or mute the thread https://github.com/notifications/unsubscribe/AAs6FU9U3kxC9DTpcNbTgNf0eEiokPhoks5qQxtPgaJpZM4JA3Ye .

Klortho commented 8 years ago

If it's very easy for you, that would be great! It would take me a while to remember how to do it, and I'm a bit swamped at the moment.

jberger commented 8 years ago

I'm preparing the release now. I realize how much I've grown as a Perl developer since the last time I looked at this :-P. I've revamped the Changes file and now I'm evaluating if the build process can be simplified.

jberger commented 8 years ago

Aaaaaaand ... released!

Klortho commented 8 years ago

Wow, thanks!

I realize how much I've grown as a Perl developer

I've regressed. In Perl, that is. I'm mostly working in JS now. I love how low-friction npm is. Of course -- I imagine cpan and perl tools have lowered the barriers, too. I've been musing lately that maybe soon there will be no difference between "developing" and "publishing/releasing". And packages will get smaller and smaller, until we get to the point that system are built up from a collection of versioned functions.

Klortho commented 8 years ago

Here is the diff: https://github.com/Klortho/Physics-Unit/compare/8e994f7a...74459ebb

churib commented 8 years ago

Many thanks you both!