Kludex / fastapi-microservices

Fully Python async FastAPI project! 🚀
MIT License
441 stars 43 forks source link

Wrong class instance #72

Closed SarloAkrobata closed 1 year ago

SarloAkrobata commented 1 year ago

https://github.com/Kludex/fastapi-microservices/blob/cee0a7df02377c9980ecf4fc41e321e96e41c8d9/users/app/crud/users.py#L6

It should be like this: crud_user = CRUDUser(User)

Also I think better way would be like this, because it makes open for extendibility (eg. write or overwrite specific queries, the features of repository pattern):


from app.models.users import User
from app.schemas.user import UserInDB, UserUpdateDB

class CRUDUser(CRUDBase[User, UserInDB, UserUpdateDB]):
    pass

crud_user = CRUDUser(User)
Kludex commented 1 year ago

Thanks. PR welcome.

Kludex commented 1 year ago

This was solved already. 👍