Kludex / fastapi-responses

Find HTTPExceptions and turn them into documented responses! :tada:
https://github.com/Kludex/fastapi-responses
MIT License
92 stars 11 forks source link

➖ Drop support for Python 3.6 and 3.7 #17

Closed ricardo-emanuel01 closed 1 year ago

ricardo-emanuel01 commented 1 year ago

There is something else that I need to change to remove support for Python 3.6 and 3.7?

Kludex commented 1 year ago

Can we add https://github.com/asottile/pyupgrade#as-a-pre-commit-hook ?

ricardo-emanuel01 commented 1 year ago

I've never used this, please let me know if something needs to be changed

Kludex commented 1 year ago

I've never used this, please let me know if something needs to be changed

I'll set the pre-commit on the pipeline later, but for now, can you do pip install pre-commit and then pre-commit run --all-files locally, then check the diff, and push?

ricardo-emanuel01 commented 1 year ago

Now I'm investigating the tests problem

Kludex commented 1 year ago

You need to add httpx on the requirements.

The problem here is that we didn't pin the dependencies. 😅

ricardo-emanuel01 commented 1 year ago

It didn't work, even after adding httpx. I had to update pytest and pytest-cov, and only after that, I added httpx. Finally, the tests worked.

ricardo-emanuel01 commented 1 year ago

Now the tests are running and passing

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (72dbf4d) 100.00% compared to head (2c86b4f) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 3 3 Lines 73 73 ========================================= Hits 73 73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Kludex commented 1 year ago

Thanks :)