search

Kludex / python-multipart

A streaming multipart parser for Python.
https://multipart.fastapiexpert.com/
Other
316 stars 54 forks source link

README.md: hyperlink to documentation #126

Closed yecril23pl closed 6 months ago

Kludex commented 7 months ago

@yecril23pl Do you mind changing this to what we have in Starlette: https://github.com/encode/starlette (the "Documentation" between ---?

yecril23pl commented 7 months ago

@yecril23pl Do you changing this to what we have in Starlette: https://github.com/encode/starlette (the "Documentation" between ---?

Of course I do. A URL is not something that a reader would like to see. It is like having a source reference in running text instead of a footnote.

Kludex commented 7 months ago

Sorry, I had a typo on my message.

Kludex commented 7 months ago

Feel free to open a PR analogous to what we have in Starlette. I'll close this for now.

Kludex commented 6 months ago

I've merged this because I didn't know how to reach the documentation 👀

Thanks 🙏

yecril23pl commented 6 months ago

Wow. Just wow. Please be aware that this is not some random Python package, it is the official replacement for bundled cgi that has been deprecated. You are a Python VIP now, please act accordingly 😉

Kludex commented 6 months ago

Wow. Just wow. Please be aware that this is not some random Python package, it is the official replacement for bundled cgi that has been deprecated. You are a Python VIP now, please act accordingly 😉

Excuse me?

yecril23pl commented 6 months ago

I understood this exchange as you refusing to acknowledge my argument against your review. While this is a common occurrence in private projects, projects that have gained crucial external importance such as this one cause earthquakes in the community if under authoritarian management (e.g. XFree86).

Kludex commented 6 months ago

Locking this to avoid further heat discussion that does not benefit anyone.