KlugerLab / ALRA

Imputation method for scRNA-seq based on low-rank approximation

MIT License

71 stars 19 forks source link

Closed inoue0426 closed 2 years ago

inoue0426 commented 2 years ago

Hi,

I found this library doesn't work because of the change by R 4.2.0.

if (class(A_norm) != 'matrix') { doesn't work and it should use if (!(any(grepl("matrix", class(A_norm), ignore.case = TRUE)))) {

Can I make a Pull Request for that?

SamGG commented 2 years ago

Could it be simpler?

!('matrix' %in% class(A_norm))
all(class(A_norm) != 'matrix')

inoue0426 commented 2 years ago

Looks good to me!

linqiaozhi commented 2 years ago

Yes, please make a PR. Thanks so much. @inoue0426

inoue0426 commented 2 years ago

@linqiaozhi Thanks! I created PR.

inoue0426 commented 2 years ago

19 This is merged to main. So close to this issue.