Klumpat / e3-macro-builds

Automatically exported from code.google.com/p/e3-macro-builds
0 stars 0 forks source link

Add path structure to let the macro run in a self contained directory #16

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I have created an "e3" directory in my macros directory and put the entire 
macro build in it.

Example Full Path: C:\eq\MQ2_UF\Macros\e3\

I have successfully hard coded "e3\" in all places to enable the macro to 
function. Need to test changing the hard coded "e3\" to a variable

Original issue reported on code.google.com by sorvani on 13 Sep 2012 at 1:24

GoogleCodeExporter commented 8 years ago
Make sure to check out the [FilePaths] section of Macro_Inis/e3_Settings.ini, 
if you haven't already seen it.  Should make your job a bit easier.

Original comment by iKillpeq@gmail.com on 13 Sep 2012 at 7:40

GoogleCodeExporter commented 8 years ago
ok after testing, there is no method available to have a dynamic path in a 
#include line. so that means it is not possible to have the macro function 
correctly no matter what sub folder it is in.

All the lines can be hard coded to the correct directory though. What do you 
think about putting it into a sub folder? the two attached diffs show you what 
changes are required to successfully run e3 from a sub folder in the macros 
directory.

Original comment by sorvani on 13 Sep 2012 at 4:04

GoogleCodeExporter commented 8 years ago
I like the idea of having e3 in it's directory.  Keeps things nice and clean 
for those who run multiple macros.  My only concern is that it may cause 
confusion for people who are just starting out with MQ2.  Would be easy enough 
to add a patch on the downloads page that would included the necessary edits 
for those who want it.

Original comment by iKillpeq@gmail.com on 13 Sep 2012 at 6:02

GoogleCodeExporter commented 8 years ago
Well for those starting out it is simply a matter of properly unzipping the 
download to an e3 directory inside the macros directory instead of directly 
into the macro directory.  Always have issues there no matter what some people 
just do not get it. 

The other difference is to launch the macro in game you need to pretend the 
subdirectory /mac e3\e3.mac 

I already added my own alias do that /e3 will fire it up. 

Original comment by sorvani on 13 Sep 2012 at 6:07

GoogleCodeExporter commented 8 years ago
The more I think about it, the more the idea grows on me.  Just keeps things 
cleaner altogether.  I'm also thinking it wouldn't be a bad idea to move all 
the #includes, and directory related stuff into e3.mac, to keep things clear 
and concise.

Original comment by iKillpeq@gmail.com on 13 Sep 2012 at 6:35

GoogleCodeExporter commented 8 years ago
Well if you look at the diffs I posted there is not a ton of things to change. 
I did have a problem with the FilePaths section, it was not actually writing to 
the existing INI from the zip (which had no paths listed in it). I deleted the 
INI completely and it rewrote everything correctly. 

But that problem was in the middle of getting all the "e3\" added to all the 
write places and I was extremely tired. I'll put the INI from the zip back in 
the folder and the restart the macro next time I log in and see what happens. 

Original comment by sorvani on 13 Sep 2012 at 6:44

GoogleCodeExporter commented 8 years ago
ok i have this all working on my system now. do you want me to commit a change 
or post a .diff ?

Original comment by sorvani on 29 Sep 2012 at 11:28

GoogleCodeExporter commented 8 years ago
ok, made changes for this in a branch so I don't affect the main macro for now.

Original comment by sorvani on 18 Nov 2012 at 2:35

GoogleCodeExporter commented 8 years ago
this is done and stable i have had no issues running with the branched version 
where it is all in the e3 directory except for e3.mac

Original comment by sorvani on 24 Nov 2012 at 3:15

GoogleCodeExporter commented 8 years ago

Original comment by iKillpeq@gmail.com on 31 Jul 2013 at 7:12