Error in e3_Macro_Basics.inc added in revision 16

[GoogleCodeExporter]

Looking at the diff for revision 16 i noticed a /timed 200 was added with no 
command after it. this does nothing except waste a clock cycles and memory. 
also the basic layout of the new code make it questionable as to what was 
intended here.

@@ -1251,6 +1251,11 @@
        /call e3_Cast ${Me.ID} "Throne of Heroes" alt

        /if (${overrideTwist}) /timed 200 /squelch /twist start
+       
+   } else {/if (${Me.Hiding}) {
+       /doability Hide 
+       /timed 200
+       }

Original issue reported on code.google.com by sorvani on 28 Sep 2012 at 3:56

[GoogleCodeExporter]

That is the beginning of the rogue code for unhiding and using Throne of Heroes 
its not quite finished.

Original comment by Gatean...@gmail.com on 28 Sep 2012 at 7:04

[GoogleCodeExporter]

I think what Gat is trying to do, is unhide before using throne.  I'm guessing 
he's wanting something like this,

|------------------------------------------------------------|
|- Uses 'Lessons of the Devoted', on all bots who are able. -|
|------------------------------------------------------------|
#event Lessons "<#*#> Lessons"
SUB event_Lessons
/if (${Debug}) /echo |- EVENT_Lessons ==>

    /if (!${Me.AltAbilityReady[Lessons of the Devoted]}) {
        /docommand ${ChatToggle} Lessons of the Devoted is not ready.
    } else {

        /if (${Me.Class.ShortName.Equal[BRD]} && ${MelodyStatus} || ${Twist.Twisting}) {
            /squelch /twist stop
            /declare overrideTwist bool outer TRUE
        } else /if (${Me.Class.ShortName.Equal[ROG]}) {
                    /doability Hide
                }

        /call e3_Cast ${Me.ID} "Lessons of the Devoted" alt

        /if (${overrideTwist}) /timed 50 /squelch /twist start
    }

/if (${Debug}) /echo <== EVENT_Lessons -|
/RETURN

I'll commit a fix with my next update, if it hasn't been done by someone else 
yet.

Original comment by iKillpeq@gmail.com on 29 Sep 2012 at 9:39

[GoogleCodeExporter]

Also, all the events to use vet AAs follow the same format.  The idea behind 
the /timed was to engage MQ2Twist on a bard, after casting a spell.  I used 
/timed since you don't actually get a casting bar on a bard's screen.  This way 
you don't have to use a straight /delay 200.  Whatever changes you make to the 
Thrones event should be updated in subsequent events.

Original comment by iKillpeq@gmail.com on 29 Sep 2012 at 9:44

[GoogleCodeExporter]

I understand the reason to use /timed. I was just pointing out that it was used 
incorrectly in that snippet that was added.

Original comment by sorvani on 29 Sep 2012 at 11:27

[GoogleCodeExporter]

Original comment by sorvani on 30 Sep 2012 at 12:06

[GoogleCodeExporter]

Original comment by Gatean...@gmail.com on 5 Oct 2012 at 11:53

• Changed state: Fixed