search

KlutzyBubbles / lc-better-emotes

Lethal company mod that alters the integration method of MoreEmotes and adds more config options
https://thunderstore.io/c/lethal-company/p/KlutzyBubbles/BetterEmotes/
MIT License
4 stars 1 forks source link

Conflict with LCVR #16

Closed Nathan22211 closed 8 months ago

Nathan22211 commented 8 months ago

not tested it personally but it seems that the mod dev did find a conflict with better emotes and his mod (quoted from his compatibility sheet)

"BetterEmotes and LCVR are interfering with each other when updating the player controller animator"

KlutzyBubbles commented 8 months ago

not tested it personally but it seems that the mod dev did find a conflict with better emotes and his mod (quoted from his compatibility sheet)

"BetterEmotes and LCVR are interfering with each other when updating the player controller animator"

This is a known issue with MoreEmotes (the mod this one is heavily reliant on) and this will be an issue until MoreEmotes fixes it or when i learn how to animate things, whichever comes first (probably MoreEmotes updating).

For now disabling or uninstalling the mod should cause no issues, because i havent added the sign emote yet BetterEmotes is still client side and anyone can choose to have it installed or not.

Edit: With the way thunderstore does readme updates i cant update the readme without pushing a new mod version, and i dont like to push new updates unless something actually changes

Nathan22211 commented 8 months ago

there's a toggle in the config for more emote if my memory serves me right that fixes it, and it seems other emote mods don't have this issue from looking at the spreadsheet

KlutzyBubbles commented 8 months ago

there's a toggle in the config for more emote if my memory serves me right that fixes it, and it seems other emote mods don't have this issue from looking at the spreadsheet

I am still working on updating the mod (code / progress can be found https://github.com/KlutzyBubbles/lc-better-emotes/tree/moreemotes-1.3.1).

When that is complete and working, i would imagine the VR incompatibilities will also sort themselves out, but if they dont, then i can work on it.

KlutzyBubbles commented 8 months ago

there's a toggle in the config for more emote if my memory serves me right that fixes it, and it seems other emote mods don't have this issue from looking at the spreadsheet

I have recently published v1.4.0, not sure if it still has the incompatibilities.

I dont believe much has changed so it probably still doesn't work well but i dont have the setup to test it

Nelots commented 8 months ago

I just loaded the game up in VR and I can confirm the mods are still incompatible.

For now disabling or uninstalling the mod should cause no issues, because i havent added the sign emote yet BetterEmotes is still client side and anyone can choose to have it installed or not.

On another note, now that you've added the sign emote, does that mean the mod is no longer client-sided and can't be removed if one person wants to use VR?

KlutzyBubbles commented 8 months ago

On another note, now that you've added the sign emote, does that mean the mod is no longer client-sided and can't be removed if one person wants to use VR?

I am not entirely sure, i will add that to some things i should test. But the implementation is the same as MoreEmotes (i havent had time to properly alter the integration methods just yet) so if it happens in MoreEmotes it will more than likely happen with BetterEmotes.

This information is very helpful btw, thank you :)

edit: If the emotes end up not working without the client server sided stuff, i have an idea to disable self player animations if incompatible mods exist while still running the required networking code, as the networking code doesnt touch the player models at all. (this is more here to remind myself of the solution incase i forget)

KlutzyBubbles commented 8 months ago

I just loaded the game up in VR and I can confirm the mods are still incompatible.

For now disabling or uninstalling the mod should cause no issues, because i havent added the sign emote yet BetterEmotes is still client side and anyone can choose to have it installed or not.

On another note, now that you've added the sign emote, does that mean the mod is no longer client-sided and can't be removed if one person wants to use VR?

there's a toggle in the config for more emote if my memory serves me right that fixes it, and it seems other emote mods don't have this issue from looking at the spreadsheet

I have recently posted v1.4.1 which should add support for LCVR. It should disable emotes for anyone using VR, but still let VR players view non VR players emotes.

Please note that you will get console errors if not all other people in the lobby have BetterEmotes also.