search

KmanOz / KmanSonoff

Firmware for ESP8266 based itead Sonoff switches for use with HomeAssistant / mqtt
MIT License
282 stars 39 forks source link

using lmroy version... #21

Open lolouk44 opened 6 years ago

lolouk44 commented 6 years ago

A couple of questions / comments if I may: 1) your step 2. Clone the LMROY version of the mqtt library refers to LMROY but the github is imroy (starting with an i) Threw me off a bit :) You may want to update your README.md 2) if one must use imroy's files, why do you #include <PubSubClient.h> instead of #include "PubSubClient.h"? The latter would look for a local copy (in the sketch folder) first then the libraries. This would mean one is not forced to use imroy's library for all arduino projects. Or am I missing something? (I'm still a bit of a n00b with arduino).

Thanks

thepotoo commented 6 years ago

This is what I did - I moved the files

MQTT.cpp
MQTT.h
PubSubClient.cpp
PubSubClient.h
PubSubClient_JSON.h

from the imroy pubsubclient folder and put them in the same directory as KmanSonoff_v1.00sc.ino

Then edit KmanSonoff_v1.00sc.ino and change #include <PubSubClient.h> to #include "PubSubClient.h"