Unable to send in compiler flags

Kmer-File-Format / kff-cpp-api

A C++ API to read and write kff files

GNU Affero General Public License v3.0

9 stars 9 forks source link

Unable to send in compiler flags #16

Closed adamnovak closed 9 months ago

adamnovak commented 9 months ago

The CMake file sets CMAKE_CXX_FLAGS with a set(), which can't be overridden on the cmake command line with a -D. So it's not possible to pass additional compiler flags (such as -fPIC for using this library as a dependency of a shared library) into the build.

https://github.com/Kmer-File-Format/kff-cpp-api/blame/c490ddb603074b0c4c3efecc3a3c8506b059ffaf/CMakeLists.txt#L15

yoann-dufresne commented 9 months ago

Hi,

Thanks from reaching us. I updated the CMakeLists.txt so you can now pass these flags from the command line. Do not hesitate if you have other questions.

Yoann