search

KmolYuan / four-bar-rs

FouršŸ€bar is a simulator, a synthesizing tool for four-bar linkage mechanism.
https://crates.io/crates/four-bar
GNU Affero General Public License v3.0
6 stars 0 forks source link

Tries extracting git hash even from distfile #5

Closed 0-wiz-0 closed 4 weeks ago

0-wiz-0 commented 1 month ago

Yesterday I tried fixing the pkgsrc package for four-bar-rs because it was not building. pkgsrc uses the v7.0.0 tag tarball from github. During the build of four-bar-ui, build.rs tries to run git to find out a revision, which is later used in four-bar-ui/src/app.rs via env!("GIT_HASH"). I don't know how this is supposed to work with the distfile, because that does not contain the git metadata files, so even if I provide a git binary during the build, running it will fail.

How is this supposed to work?

The workaround I used in pkgsrc is to delete four-bar-ui/build.rs and replace env!("GIT_HASH") from the pkgsrc infrastructure.

KmolYuan commented 4 weeks ago

Fixed in 4a4dcfb.

0-wiz-0 commented 4 weeks ago

Confirmed fixed in 7.0.1, thank you!