search

KnapsackPro / knapsack_pro-ruby

Knapsack Pro gem splits tests across parallel CI nodes and makes sure that tests run in optimal time
https://knapsackpro.com
MIT License
132 stars 27 forks source link

Does `rake knapsack_pro:rspec_test_example_detector` need to run if there aren't any slow specs? #223

Closed technicalpickles closed 1 year ago

technicalpickles commented 1 year ago

While doing some local testing, I have sometimes seen the log output from this line:

https://github.com/KnapsackPro/knapsack_pro-ruby/blob/4d9dc1436470995773aa080d8054f6c587aef91b/lib/knapsack_pro/base_allocator_builder.rb#L46

Does the rake task still need to run if slow_test_files.size == 0? It is relatively fast (15s locally), but if there aren't any slow specs, it'd be nice to save a little time.

ArturT commented 1 year ago

I guess it could be skipped, then. We'll have to check that.

ArturT commented 1 year ago

@technicalpickles This is solved in the knapsack_pro gem 5.7.0 version. Please update the knapsack_pro gem in your project.