KnapsackPro / knapsack_pro-ruby

Knapsack Pro gem splits tests across parallel CI nodes and makes sure that tests run in optimal time
https://knapsackpro.com
MIT License
131 stars 27 forks source link

Slow test analysis runs even when there's no slow tests #224

Closed ngan closed 1 year ago

ngan commented 1 year ago

We don't always build every single test but it looks like the slow test analysis always runs even when there's no slow test: https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/lib/knapsack_pro/base_allocator_builder.rb#L55

No slow tests being that slow_test_files = get_slow_test_files is an empty array.

An optimization to make would be to see if we actually got any slow tests back from the get_slow_test_files call. If we got an empty array, it should just bypass the analysis completely.

shadre commented 1 year ago

Thanks for the suggestion.

We are aware of that and plan to address this. I'm closing this as it's a dup of: https://github.com/KnapsackPro/knapsack_pro-ruby/issues/223.

ArturT commented 12 months ago

@ngan This is solved in the knapsack_pro gem 5.7.0 version. Please update the knapsack_pro gem in your project.