ArturT
commented
7 months ago I reproduced the error.
Minitest shows the Nothing ran for filter: error and exits with 1 as exit code (error exit code) when test files returned from the Queue API include pending tests or an empty test file with no test cases.
I use the knapsack_pro gem 6.0.4.
I prepared PRs to reproduce the problem for our team:
- https://github.com/KnapsackPro/knapsack_pro-ruby/pull/241
- https://github.com/KnapsackPro/rails-app-with-knapsack_pro/pull/57
The output:
➜ rails-app-with-knapsack_pro git:(debug-minitest-5.22.0) bin/knapsack_pro_queue_minitest
==================================================
Tests (mocked API response):
["test/minitest_spec_rails/shared_examples_test.rb"]
==================================================
D, [2024-02-06T19:06:10.015472 #90231] DEBUG -- : [knapsack_pro] Test suite time execution queue recording enabled.
Run options: --verbose --seed 50180
# Running:
Nothing ran for filter:
----------After Subset Queue Hook - run after subset of test suite----------==================================================
Tests (mocked API response):
["test/controllers/pending_controller_test.rb"]
==================================================
Run options: --verbose --seed 49280
# Running:
Nothing ran for filter:
----------After Subset Queue Hook - run after subset of test suite----------==================================================
Tests (mocked API response):
[]
==================================================
----------After Queue Hook - run after test suite----------W, [2024-02-06T19:06:10.056715 #90231] WARN -- : [knapsack_pro] 2 test files were executed on this CI node but the recorded time was lost due to:
W, [2024-02-06T19:06:10.056732 #90231] WARN -- : [knapsack_pro] 1. Please ensure you do not remove the contents of the .knapsack_pro directory between tests run.
W, [2024-02-06T19:06:10.056740 #90231] WARN -- : [knapsack_pro] 2. Ensure you've added Knapsack::Adapters::RSpecAdapter.bind in your rails_helper.rb or spec_helper.rb. Please follow the installation guide again: https://knapsackpro.com/perma/ruby/installation-guide
W, [2024-02-06T19:06:10.056745 #90231] WARN -- : [knapsack_pro] 3. Another potential reason for this warning is that all your tests are empty test files, pending tests, or they have syntax errors, and the time execution was not recorded for them.
D, [2024-02-06T19:06:10.143137 #90231] DEBUG -- : [knapsack_pro] POST http://api.knapsackpro.test:3000/v1/build_subsets
D, [2024-02-06T19:06:10.143159 #90231] DEBUG -- : [knapsack_pro] API request UUID: e055db31-5cde-4800-b6f5-1926cddbbcfd
D, [2024-02-06T19:06:10.143168 #90231] DEBUG -- : [knapsack_pro] API response:
D, [2024-02-06T19:06:10.143177 #90231] DEBUG -- : [knapsack_pro]
D, [2024-02-06T19:06:10.143190 #90231] DEBUG -- : [knapsack_pro] Saved time execution report on Knapsack Pro API server.
Coverage report generated for Unit Tests to /Users/artur/Documents/github/knapsack-pro/rails-app-with-knapsack_pro/coverage. 2 / 2 LOC (100.0%) covered.
SimpleCov failed with exit 1%
➜ rails-app-with-knapsack_pro git:(debug-minitest-5.22.0) echo $?
1Internal story for reference: https://trello.com/c/hJVGPrmE
@davidwessman Could you use the old Minitest version until this is solved? Thanks.
davidwessman
Hello!
After upgrading to minitest 5.22.0 we are getting a failed status from
bundle exec rake knapsack_pro:queue:minitesteven if all test cases pass.The failing jobs has the output
Nothing ran for filter:and the passing jobs does not.My guess is that this change for
empty_run!will generate a warning where it previously did not: https://github.com/minitest/minitest/compare/v5.21.2...v5.22.0#diff-b43f1192f616004aa819abdb67ebe90528572c49ec805b9ad66ce45e1afce97bR177