Raise when KNAPSACK_PRO_CI_NODE_TOTAL or KNAPSACK_PRO_CI_NODE_INDEX is missing and can't be determined from supported CI environments, instead of defaulting to arbitrary numbers.
Changes
ci_node_total no longer defaults to 1 and ci_node_index no longer defaults to 0. Instead, an error is raised, like with missing ci_node_build_id or test_suite_token.
Checklist reminder
[x] You follow the architecture outlined below for RSpec in Queue Mode, which is a work in progress (feel free to propose changes):
Pure: lib/knapsack_pro/pure/queue/rspec_pure.rb contains pure functions that are unit tested.
Extension: lib/knapsack_pro/extensions/rspec_extension.rb encapsulates calls to RSpec internals and is integration and e2e tested.
Runner: lib/knapsack_pro/runners/queue/rspec_runner.rb invokes the pure code and the extension to produce side effects, which are integration and e2e tested.
Story
https://trello.com/c/jB6bXgzH/192
Description
Raise when
KNAPSACK_PRO_CI_NODE_TOTALorKNAPSACK_PRO_CI_NODE_INDEXis missing and can't be determined from supported CI environments, instead of defaulting to arbitrary numbers.Changes
ci_node_totalno longer defaults to 1 andci_node_indexno longer defaults to 0. Instead, an error is raised, like with missingci_node_build_idortest_suite_token.Checklist reminder
lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and e2e tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and e2e tested.