Kneelawk / WiredRedstone

Adds redstone wires and stuff
https://modrinth.com/mod/wiredredstone
MIT License
14 stars 7 forks source link

Fix Redstone Assembler output logic #14

Closed aspargas2 closed 2 years ago

aspargas2 commented 2 years ago

The canAcceptOutput function was mutating the count of the passed ItemStack, causing the Redstone Assembler to sometimes output too few items depending on what was already in the output slots.

This issue can be reproduced simply by setting the Redstone to crafting mode and putting a bunch of iron ingots into the crafting grid. After a stack of iron nuggets has accumulated in the output slots, fewer than 9 nuggets will be produced for each subsequent ingot.

Kneelawk commented 2 years ago

Thanks for this catch. This looks good.

Kneelawk commented 2 years ago

Ok, this fix is published in v0.3.6+1.18.2 and v0.4.7+1.19 on Modrinth and CurseForge.