Kneelawk / WiredRedstone

Adds redstone wires and stuff
https://modrinth.com/mod/wiredredstone
MIT License
14 stars 6 forks source link

Create Links don't visually connect to wires unless powered. #5

Closed Aquaeyes closed 2 years ago

Aquaeyes commented 2 years ago

image image It's just uh, pretty much what it says on the tin. Amazing mod, and my gOD do I love the multipart support.

Kneelawk commented 2 years ago

I haven't actually explored Create compatibility much yet. Thanks for reporting this!

ardissaps commented 2 years ago

I haven't actually explored Create compatibility much yet. Thanks for reporting this!

same with me, still function as normal and works, just minor visual glitch.

Lamp : image

Gearshift image

Maybe some others that tagged as redstone or something need to be made always connect the model?

Kneelawk commented 2 years ago

I have a plan to fix this one though it won't be too clean. From what I can tell, many blocks give no indication that they do anything with redstone. My plan here is to add a block-tag that specifies that a block should always be connected to by red-alloy/insulated wire. That way datapacks can force wire to connect to blocks.

I might eventually do something similar for bundled cable too, though that would only really be useful once I get the bundled-cable API added.

In some of these cases however, the wire is not actually supposed to connect. Uninsulated wire is designed to power all blocks around it without actually visually connecting to them. The red-alloy-wire's visual connections actually should only indicate which blocks the wire can receive a redstone signal from.

I don't think I'll be able to get this out in v0.3.2 but hopefully in v0.3.3.

ardissaps commented 2 years ago

For now I just manually put additional wire on the side of the said block as it supported by lib multipart. No problem. It is only for aesthetic suggestion. But when I think more, I will just pretend (maybe the red cabble connected underground like some centimeter), just positively think about that and problem solved on my end. hahaha

But, it can render when connected to spesific gate, why wouldn't it connected to another similiar mechanic? (including gate from other mods and/or redstone link from create). Or maybe it is on Create side that should be fixed maybe their device have wrong/mismatch as not detected as gate or something. Functionality still great, everything works perfectly, no hurry (1.18.2).

Kneelawk commented 2 years ago

Ok, something is very strange with specifically Create's Redstone Links. They seem to have the ability to detect a redstone signal from a wire, even if the wire is not sending power in the Link's direction. If a wire goes near a Redstone Link, the link will receive power from it. Even if the wire is not connected to the Link (e.g. wire on the opposite side of the block from the Create Redstone Link). I'm not really sure how to fix this on my end :/

I will be working on the system to allow wires to connect to blocks with specific block-tags though which should hopefully at least fix the visual issues here.

Kneelawk commented 2 years ago

Ok, Wired Redstone v0.3.3+1.18.2 has been released that incorporates the block-tags addition.

Kneelawk commented 2 years ago

Please let me know if you encounter any bugs with the block-tags system. :)

ardissaps commented 2 years ago

Thank you very much, it works. I also just figured out that Create Redstone Link cannot be rotated (can only face north), I'll report on Create. image