search

KnightHacks / DiscordBot-New

GNU Affero General Public License v3.0
0 stars 1 forks source link

Add slash commands for role/skill assignment #13

Closed suneettipirneni closed 3 years ago

suneettipirneni commented 3 years ago

Addresses #11

Adds slash commands:

/addrole, /removerole, /addskill, /removeskill,

Screen Shot 2021-06-14 at 10 18 33 PM

Because of slash commands it is also necessary to update you env to include the GUILD_ID.

rob-3 commented 3 years ago

Looks pretty good. Consider using add_role and remove_role to be more idiomatic. Also, is there any reason you marked them as private?

rob-3 commented 3 years ago

Oh looking more closely I guess that matches how you use the command. Still unsure of why they are marked with _ though.

suneettipirneni commented 3 years ago

Oh looking more closely I guess that matches how you use the command. Still unsure of why they are marked with _ though.

I've changed the names to snake case, and removed the leading underscores. I've also made the message ephemeral.