search

KnightHacks / DiscordBot-New

GNU Affero General Public License v3.0
0 stars 1 forks source link

Add a linter #4

Closed rob-3 closed 3 years ago

rob-3 commented 3 years ago

I use https://github.com/Microsoft/pyright to lint this project and I get a number of warnings in various files, some of which do actually indicate problems. We should standardize a python linter for dev team projects and then fix the errors everywhere.

zenith110 commented 3 years ago

Would this linting happen for pr reviews, or after it's merged into the branch?

rob-3 commented 3 years ago

Either is fine. I'm not actually that well-versed in the python ecosystem and CD/CI so use your discretion. I just like linters in my editor.

TorrentofShame commented 3 years ago

Should use https://github.com/python/mypy instead if you want type checking in the linter.

rob-3 commented 3 years ago

We added flake8 as per #9