Frontend/landing page - Githubissues

KnightHacks / hackathon-site-2021

Hackathon site for KnightHacks '21

MIT License

3 stars 2 forks source link

Frontend/landing page #68

Closed andreahern closed 3 years ago

andreahern commented 3 years ago

Made landing page. Resolves #42 and #45

aileenpongnon commented 3 years ago

✗ Mentions solved issue # ✗ Code is commented ✓ Responsiveness across viewports ✓ PR has the label "frontend"

missing a couple things from the PR checklist; I also think we should change the responsiveness of the volume & menu button on smaller desktop views. when resizing it gets super small. I think there could be some padding of the welcome to KH content as well so that there's always space between the content and borders of the rectangle even when its resized at the smallest desktop view

rob-3 commented 3 years ago

I think that on small views you should reorganize the grid to collapse the side columns and move the icons to the top of the page. Otherwise looks very pretty!

aileenpongnon commented 3 years ago

looking beautiful so far!! more minor adjustments:

there's a certain breakpoint (maybe md?) where there's no padding between the logo and bg borders, all others are good though
when the menu button is clicked, for some reason the "Welcome" on the landing page gets highlighted and remains highlighted while the menu is open. just me or is that happening for you too?

andreahern commented 3 years ago

looking beautiful so far!! more minor adjustments:

there's a certain breakpoint (maybe md?) where there's no padding between the logo and bg borders, all others are good though

when the menu button is clicked, for some reason the "Welcome" on the landing page gets highlighted and remains highlighted while the menu is open. just me or is that happening for you too?

Both are issues that are present but I don't believe this should be to pr to fix those issues. We can work to fix those at a later point once this has been merged in and others begin working on there issues.