search

KnightHacks / hackathon-site-2021

Hackathon site for KnightHacks '21
MIT License
3 stars 2 forks source link

Frontend/new menu #77

Closed andreahern closed 3 years ago

andreahern commented 3 years ago
ISSUE

Resolves issue(s) #76.

DESCRIPTION

Uses new library called HeadlessUI from the creators of TailwindCSS to refactor the menu into a Dialog and adds better transitions.

CHECKLIST

✓ Code is commented

✓ Responsiveness across viewports

✓ Labeled "frontend"

aileenpongnon commented 3 years ago

I would move the items in the menu a little closer to the center of the page or add a bit more padding (similar positioning to how it was before) just so there isn't as much empty space

aileenpongnon commented 3 years ago

include the outline on the buttons in the menu on focus for accessibility, it can be restyled instead of removed

aileenpongnon commented 3 years ago

this can be merged in after conflicting files are resolved, both required reviews are completed