search

KnightHacks / hackathon-site-2021

Hackathon site for KnightHacks '21
MIT License
3 stars 2 forks source link

Frontend/schedule page #88

Closed aileenpongnon closed 3 years ago

aileenpongnon commented 3 years ago
ISSUE

Resolves #47.

DESCRIPTION

renders Schedule page with data populated from JSON. includes colored tags from schedule's legend using color-hash library

CHECKLIST

✓ Code is commented

✓ Responsiveness across viewports

✓ Labeled "frontend"

rob-3 commented 3 years ago

Looks good, but your comments were showing up on the page. I wrote a short patch to fix that; it is an easy fix. You can take a look if you're interested. You should also probably use a lowercase C for Content since it is a variable and not really a module/type. Also merge in the latest frontend-dev.

aileenpongnon commented 3 years ago

I do get a warning for not using a key prop in a list that should be fixed before this is merged.

I'm trying to reproduce this but I'm not getting this same warning? I'll go ahead and include the prop though

rob-3 commented 3 years ago

I do get a warning for not using a key prop in a list that should be fixed before this is merged.

I'm trying to reproduce this but I'm not getting this same warning? I'll go ahead and include the prop though

Have you checked the browser log?

aileenpongnon commented 3 years ago

I do get a warning for not using a key prop in a list that should be fixed before this is merged.

I'm trying to reproduce this but I'm not getting this same warning? I'll go ahead and include the prop though

Have you checked the browser log?

good point, I see it now

rob-3 commented 3 years ago

Looks good; approved!