search

KnightMiner / Inspirations

Mod adding various smaller features to Minecraft
MIT License
44 stars 18 forks source link

Adding Leather Works support #115

Closed Balint66 closed 5 years ago

Balint66 commented 5 years ago

Adding plugin for Leather Works mod, and updating forgegradle to be able to use curseforge maven API.

KnightMiner commented 5 years ago

Can you fix formatting to match the rest of the mod? Notably, brackets on the same line and sorted imports.

Also, I think I can guess by looking at the code, but mind giving a brief description of what this plugin does for the sake of future reference?

Side note, unless I'm calling that mods APIs I skip it as a build dependency so I don't need to always boot with it. Currently I just test using the libs folder, but I like the curseforge maven idea. Maybe keep it but leave leatherworks commented out?

Balint66 commented 5 years ago

Of course. I will reformat my code and give a better description.

Oh, yes, sorry I forgot to comment out/delete the leather works dependenci line, my bad. 😅 I used it so I can search in it in my ide so I didn't have to switch between github and the ide.

I will change my code as soon as I can get to my computer.

Balint66 commented 5 years ago

Leather Works use up the fluid instantly so it does not need any rebalance.

KnightMiner commented 5 years ago

Just wanted to update this to say the changes look good, just have not had a chance to test this yet. Will have time this weekend.

Balint66 commented 5 years ago

I'm glad to hear it. 🙂

KnightMiner commented 5 years ago

Just tested it and it looked great, seems their barrels already act a lot like cauldrons so it fits very well.