KnightMiner / Inspirations

Mod adding various smaller features to Minecraft
MIT License
44 stars 18 forks source link

Cauldron fluids option is incompatible with the Rats mod #131

Closed callumhauber closed 5 years ago

callumhauber commented 5 years ago

Mod versions are Inspirations 0.2.4 and Rats 1.1.3.

The extendCauldron option breaks the ability to make cheese by putting milk in a cauldron, probably because Inspirations does a block substitution if extendCauldron is true. Changing the option to "simple" fixes the incompatibility.

KnightMiner commented 5 years ago

Hmm, this seems like a case of us both doing the same thing, that is both have a feature to put milk in the cauldron. If you disable the Inspirations milk fluid (or fluids in cauldrons in general), does it fix your issue?

callumhauber commented 5 years ago

Disabling the Inspirations milk fluid fixed the problem. That was the first thing I tried, but it didn't work because I was using a custom modpack and there was something else messing it up. After slowly adding mods in, I found that Reliquary is the other incompatibility.

To summarize, with just Inspirations and Rats changing milk fluid to false fixes the problem. With Inspirations, Rats, and Reliquary changing extendCauldron to simple fixes the problem (or just disabling Reliquary). Time to go make issues on Reliquary's page now.

Thanks for the help!

callumhauber commented 5 years ago

When I tried to completely isolate the issue to between Rats and Reliquary, the milk to cheese recipe worked again. It appears that only when Inspirations, Rats, and Reliquary are all included that the recipe breaks.

The recipe works again when all cauldron fluids are disabled in Inspirations. Only milk needed to be disabled in Inspirations when it was just with Rats.

KnightMiner commented 5 years ago

The issue is not related to Reliquary, they just also add a milk fluid, which is why is suggested disabling cauldron fluids if the issue still happens with milk disabled.

Your answer gave me enough information, so I'll explain the issue in more detail:

As a work around, you can disable fluids in cauldrons. This will prevent things such as stews and juices from being made in the cauldron though, so that's not the best solution

I think I have an idea if how to deal with this, so I'll look into fixing it for the next release.

For my reference, crossposting Alex-The-666/Rats#28

callumhauber commented 5 years ago

I renamed the issue to be more accurate to the actual interaction. Thanks for the great explanation! I didn't notice that Reliquary added milk as a fluid when I looked through the description or the config file, so I didn't realize that's what was happening.

KnightMiner commented 5 years ago

Fixed in 0.2.5